[SA-exim] Re: SA-Exim CVS ready for testing before SA-Exim 2.3

[Brian Kendig]

A couple of ideas to toss in:

- Could you make the SA log message formats more similar?  The 
'permanently rejected' one looks like this (and the 'temporarily 
rejected' one is similar, thanks for changing these a while ago!):

SA: local_scan permanently rejected message: hits=117.0 required=5.0 
trigger=12.0 (scanned in 14/14 secs). From <cquzhaotai at usa.net> 
(host=NULL [61.129.66.34]) for brian at enchanter.net

But the 'accepted' one is:

SA: score hits=3.0 required=5.0 (scanned in 5/5 secs)

And the 'spam but accepted' one is:

SA: Flagged as Spam but accepted: Score hits=10.9 required=5.0 (scanned 
in 8/8 secs)

It would really be helpful for the 'accepted' one to say "local_scan 
accepted message: hits=3.0 (scanned in 14/14 secs). From ... (host=... 
[...]) for ..."

And for the 'spam but accepted' one to say "local_scan accepted spam: 
..." or some other wording.  This would let me easily grep on 
'temporarily', 'permanently', 'accepted message', 'accepted spam' so I 
could get stats on each category of message.

- Also, might you consider removing 'required=5.0 trigger=12.0' (or 
whatever the user has those values set to) from the messages?  You 
don't want to tell spammers how close they were to having their spam 
get past the filters...

- And in sa-exim.c, where you have the string_sprintf lines which send 
messages back to the spammer (like "451- wait for more output" and "How 
about you try again later for a little more teergrube?"), can you 
change those strings to #defines at the top of sa-exim.c, so that they 
can be easily modified all in one place?  I'm concerned that spammers 
might come to recognize these strings and immediately know they're 
going to get teergrubed... making them easier to change would encourage 
users to define their own strings so as to be less detectable by 
spammers.

Thanks for considering these!  And many many kudos to you for 
continuing to develop this great piece of software!  It's come in VERY 
handy for me!  :-)

  ____    |\/|                 Brian Kendig   Set your priorities right.
  \  /\   / ..__.    brian at enchanter net   No one ever said on his
   \/  \__\   _/   http://www.enchanter.net/  death bed, "Gee, if I'd
    \__   __  \_      Be insatiably curious.  only spent more time at
       \____\___\           Ask "why" a lot.  the office."